Replace IsDisposable with Dispose + Refactor #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusz96
changed the title
mariusz96
force-pushed
the
dispose
branch
2 times, most recently
from
0673e5b
to
334eab8
Compare
ipvalverde
reviewed
Oct 27, 2024
mariusz96
commented
Oct 27, 2024
| @@ -24,7 +24,7 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <ProjectReference Include="..\PipelineNet\PipelineNet.csproj" PrivateAssets="compile;contentfiles;build;analyzers" /> | |||
| <ProjectReference Include="..\PipelineNet\PipelineNet.csproj" /> | |||
There was a problem hiding this comment.
I removed this as it forces me to install both packages separately.
| Finally(typeof(TFinally)); | ||
| where TFinally : IAsyncFinally<TParameter, TReturn> | ||
| { | ||
| _finallyType = typeof(TFinally); |
There was a problem hiding this comment.
This is performance optimization. The finally type is already checked in where contraint.
ipvalverde
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR for #26.